Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FPS counter cleanup #549

Merged
merged 1 commit into from Jul 3, 2014
Merged

FPS counter cleanup #549

merged 1 commit into from Jul 3, 2014

Conversation

lioncash
Copy link
Member

@lioncash lioncash commented Jul 3, 2014

  • Isolate it into it's own namespace
  • Shorten function names, the namespace self-documents.
  • Just use the std I/O, we can just write directly to the stream for logging, rather than calling WriteArray.

@lioncash
FPS counter cleanup
00efaed 
- Isolate it into it's own namespace
- Shorten function names, the namespace self-documents.
- Just use the std I/O, we can just write directly to the stream for
  logging.
@lioncash
Copy link
Member Author

lioncash commented Jul 3, 2014

cc'ing @neobrain and @degasus

@degasus
Copy link
Member

degasus commented Jul 3, 2014

Why did you use a namespace instead of a class?
Otherwise LGTM

@lioncash
Copy link
Member Author

lioncash commented Jul 3, 2014

Because the current way it's used doesn't really facilitate the use of class behavior.

@Parlane
Copy link
Member

Parlane commented Jul 3, 2014

lgtm

neobrain added a commit that referenced this pull request Jul 3, 2014
@neobrain
Merge pull request #549 from lioncash/fps
be1fe80 
FPS counter cleanup
@neobrain neobrain merged commit be1fe80 into dolphin-emu:master Jul 3, 2014
@lioncash lioncash deleted the fps branch July 3, 2014 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@lioncash @degasus @Parlane @neobrain