DSPCore: update free DSP ROM messages #5617
Conversation
Source/Core/Core/DSP/DSPCore.cpp
Outdated
| else if (rom_idx == 4) | ||
| { | ||
| Host::OSD_AddMessage("You are using a free DSP ROM made by the Dolphin Team.", 8000); | ||
| Host::OSD_AddMessage("All Wii games will work correctly, and most GC games should ", 8000); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
The IPL part can be dropped too, right? |
|
@shuffle2 I took a look at the ucode uploaded by the US IPL (checksum 24b22038) and PAL IPL (checksum 6ba3b3ea). They both call a function at 0x8644, which is empty-space in the current free ROM (this is also the function needed for the CARD ucode). The IPL's sound fine to me, but I don't know if I want to say they're fully supported, since the free ROM is missing that function :/ |
|
I believe with the GameCube IPL, that there may be some sounds that aren't played right. HLE audio has an issue with sounds not ending at the right time and playing longer than they should. |
|
Any idea if IPL ucode is actually using that func for audio, or is it just builtin version of the CARD ucode? |
|
@shuffle2 It doesn't look exactly like the CARD ucode, but I can only trigger that function when I remove I think you're right, it's probably a built-in CARD ucode. I'll remove the IPL part from the displayed DSP messages. |
The GBA ucode is supported as of dolphin-emu#5524 / d51be94.
The GameCube IPL sounds the same when using the free ROM as it does when using the official ROM (and in Audacity, I couldn't visually distinguish between the waveforms). It has a reference to an unimplemented function at 0x8644 which seems to only be used in an inlined version of the CARD ucode.
ligfx
changed the title
The GBA ucode is supported as of #5524 / d51be94.