cmake: Windows fixes #5624
cmake: Windows fixes #5624
Conversation
| if(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC") | ||
| foreach(f CMAKE_C_FLAGS_DEBUG CMAKE_CXX_FLAGS_DEBUG CMAKE_C_FLAGS_RELWITHDEBINFO CMAKE_CXX_FLAGS_RELWITHDEBINFO) | ||
| if("${${f}}" MATCHES "/Zi") | ||
| string(REGEX REPLACE "/Zi" "/Z7" "${f}" "${${f}}") |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| @@ -9,6 +9,8 @@ set(CMAKE_OSX_ARCHITECTURES "x86_64") | |||
| # features can be used, not the minimum required version to run. | |||
| set(CMAKE_OSX_DEPLOYMENT_TARGET "10.9" CACHE string "") | |||
|
|
|||
| set(CMAKE_USER_MAKE_RULES_OVERRIDE "CMake/FlagsOverride.cmake") | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| @@ -0,0 +1,7 @@ | |||
| if(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC") | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
LGTM. I'd love it if a comment with https://stackoverflow.com/a/32956785 could be included somewhere, for explanation, but it works fine as stands. |
|
With cmake going to be used on windows soon what is the status of this PR. |
sccache is a ccache rewrite that supports GCC, Clang and MSVC.
Also allows better parallelization since there's no contention on a PDB file with compiling.
leoetlino
force-pushed
the
cmake_windows
branch
from
4faa769
to
6910fab
Compare
No description provided.