Common: Using size_t in PointerWrap's DoContainer apparently causes crashes #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rashes. Fixes this.
lioncash
added a commit
that referenced
this pull request
Jul 6, 2014
Common: Using size_t in PointerWrap's DoContainer apparently causes crashes
|
Hm, -1 from me. Why does this crash? Is this just a workaround for a broken feature? Or worse, does this hide an unrelated bug? |
|
@degasus @RachelBryk was the one who told me of this. |
|
I support @degasus's comment. Also, why was this merged by yourself less than 5 hours of giving people a chance to comment on it? Unless I'm missing something, please don't do that. |
|
The reason of the crash is obvious: it breaks compatibility with old ChunkFiles (32b -> 64b) and thus breaks the banner cache since the ChunkFile format version wasn't updated to match. It's also a partial revert of a merged change, which I'm perfectly fine with being merged quickly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes this.