Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvement of the desktop file #569

Merged
merged 1 commit into from Aug 12, 2014
Merged

Minor improvement of the desktop file #569

merged 1 commit into from Aug 12, 2014

Conversation

ghost
Copy link

@ghost ghost commented Jul 6, 2014

It is the same as #553 but without i18n.


Terminal=false
Type=Application
Categories=Game;Emulator;

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

@neobrain
Copy link
Member

neobrain commented Jul 6, 2014

Can you describe the changes you have done so that people who don't know the freedesktop spec by heart understand what you did, and why?

Icon=dolphin-emu
Exec=dolphin-emu
Categories=Game;

Terminal=false

This comment was marked as off-topic.

@ghost
Copy link
Author

ghost commented Jul 6, 2014

I do not know by heart. I have just mimic other desktop files of popular apps (like Firefox) after some tests.

@Tilka
Copy link
Member

Tilka commented Jul 6, 2014

@rydroid Before this gets merged you should squash the commits (with git rebase -i) and thereby remove the French changes from the git history.

@ghost
Copy link
Author

ghost commented Jul 8, 2014

Will it be ok for merging if :

  1. I reinsert a newline at end of file
  2. the file is not executable
  3. I "rebase" to delete the french translation from the history
    ?

@delroth
Copy link
Member

delroth commented Jul 13, 2014

Yeah, these three fixes SGTM.

@ghost
Copy link
Author

ghost commented Jul 20, 2014

Now this should be finally ok.

shuffle2 added a commit that referenced this pull request Aug 12, 2014
@shuffle2 shuffle2 merged commit 6a336f6 into dolphin-emu:master Aug 12, 2014
@ghost ghost deleted the desktop-file-without-translation branch August 12, 2014 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants