Globals removal #579
Merged
Globals removal #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated to avoid the keyword "extern" in the .cpp source files. They are moved into their header. |
| { | ||
| while (*ptr == ' ') | ||
| ptr++; | ||
| return ptr; | ||
| } | ||
|
|
||
| const char *skip_spaces(const char *ptr) | ||
| static const char *skip_spaces(const char *ptr) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Please use a more descriptive PR title. |
|
Marked all globals only used in one file as static and removed their header parts. I think all changes are done which doesn't require to rewrite lots of code. |
|
Looks good to me |
|
Yes, please. |
Also change globals into statics which are only used in one file
|
rebased to fix merge conflicts. Do you need more reviews or is this ready to merge? |
|
@dolphin-emu-bot rebuild |
delroth
added a commit
that referenced
this pull request
Jul 11, 2014
Mark unexported global variables and functions as statics.
CrossVR
added a commit
to CrossVR/dolphin
that referenced
this pull request
Jul 11, 2014
This commit reverts a part of pull request dolphin-emu#579.
4 tasks
Tilka
added a commit
to Tilka/dolphin
that referenced
this pull request
Jul 13, 2014
delroth
added a commit
that referenced
this pull request
Jul 13, 2014
Fix warnings unearthed by #579
Tilka
added a commit
to Tilka/dolphin
that referenced
this pull request
Jul 13, 2014
Tilka
added a commit
to Tilka/dolphin
that referenced
this pull request
Jul 13, 2014
CrossVR
added a commit
to CrossVR/dolphin
that referenced
this pull request
Jul 16, 2014
This commit reverts a part of pull request dolphin-emu#579.
CrossVR
added a commit
to CrossVR/dolphin
that referenced
this pull request
Jul 16, 2014
This commit reverts a part of pull request dolphin-emu#579.
CrossVR
added a commit
to CrossVR/dolphin
that referenced
this pull request
Jul 16, 2014
This commit reverts a part of pull request dolphin-emu#579.
CrossVR
added a commit
to CrossVR/dolphin
that referenced
this pull request
Jul 19, 2014
This commit reverts a part of pull request dolphin-emu#579.
CrossVR
added a commit
to CrossVR/dolphin
that referenced
this pull request
Jul 19, 2014
This commit reverts a part of pull request dolphin-emu#579.
CrossVR
added a commit
to CrossVR/dolphin
that referenced
this pull request
Jul 19, 2014
This commit reverts a part of pull request dolphin-emu#579.
Tilka
added a commit
to Tilka/dolphin
that referenced
this pull request
Aug 7, 2014
MikeRavenelle
pushed a commit
to MikeRavenelle/dolphin
that referenced
this pull request
Sep 2, 2014
MikeRavenelle
pushed a commit
to MikeRavenelle/dolphin
that referenced
this pull request
Sep 2, 2014
This commit reverts a part of pull request dolphin-emu#579.
MikeRavenelle
pushed a commit
to MikeRavenelle/dolphin
that referenced
this pull request
Sep 2, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Add both -Wmissing-declarations and -Wmissing-variable-declarations.
Fixes all declaration warnings, now there are lots of unused functions.