NetworkCaptureLogger: Move SSL logging #5978
Conversation
sepalani
changed the title
sepalani
force-pushed
the
net-log
branch
3 times, most recently
from
9eaa694
to
82a472c
Compare
sepalani
force-pushed
the
net-log
branch
4 times, most recently
from
a00d4cf
to
4a24d35
Compare
|
@dolphin-emu-bot rebuild |
|
Rebased on latest master. Still ready to be reviewed & merged. |
|
Rebased on latest master. |
sepalani
force-pushed
the
net-log
branch
2 times, most recently
from
0fb8656
to
0144250
Compare
|
Rebased on #8812. I slightly changed the logger interface and moved the logger to |
|
Rebased on latest master, I deleted the copy/move constructors and assignment operators as suggested #6075 (comment). I also addressed the following comments: #6075 (comment) & #6075 (comment). Still ready to be reviewed & merged. |
|
Rebased on latest master. Still ready to be reviewed & merged. |
| @@ -534,6 +534,7 @@ static void EmuThread(std::unique_ptr<BootParameters> boot, WindowSystemInfo wsi | |||
|
|
|||
| PatchEngine::Shutdown(); | |||
| HLE::Clear(); | |||
| PowerPC::debug_interface.Clear(); | |||
There was a problem hiding this comment.
Right after I hit the approve button, I realized I glossed over this. What's this for?
There was a problem hiding this comment.
It clears the debug_interface after a full shutdown (i.e. breakpoints, patches, watches, memcheck) and it also releases the network logger and its file.
I have the feeling it's an artifact that wasn't migrated when switching to Qt, I might be wrong but I don't recall adding such line when I originally created the PR.
There was a problem hiding this comment.
Ah ok, looks like this might also resolve #9325 and the issue that was mentioned there?
There was a problem hiding this comment.
Sorry, my wording was poorly chosen. By "full shutdown" I meant the game/Wii shutdown not the actual game so it won't.
After a closer look at the current code, I'll probably add a 2nd commit that removes the GUI code that takes care of the breakpoints/memchecks clearing as it's using Qt signals and Dolphin state rather than removing them on shutdown in core.
There was a problem hiding this comment.
Unnecessary GUI code removed in the 2nd commit.
PPCDebugInterface.Clear() is called by Core on shutdown instead
This PR moves the SSL logging part to its own logger class.
Not sure, if putting it inside SConfig is a good idea soI'm open to suggestions regarding where it should belong.Ready to be reviewed & merged.