D3DBase: Use the correct version of CreateDXGIFactory.

[CrossVR]

This is a big oversight on my part, I'm not sure why it seems to work correctly. I guess even though we request the incorrect version, the underlying object still supports the newer interfaces.

[mimimi085181]

As expected, this breaks directx on windows 7. When selecting directx, an error pops up:"Critical error" "GetProcAddress failed for CreateDXGIFactor2!", and Dolphin just closes when clicking ok.

[CrossVR]

@mimimi085181 Thanks for the quick test. This is a bit unexpected because Windows 7 does support the IDXGIFactory2 interface. However there is a quick workaround, since CreateDXGIFactory2 specifies the following:

This function accepts a flag indicating whether DXGIDebug.dll is loaded. The function otherwise behaves identically to CreateDXGIFactory1.

So CreateDXGIFactory2 is only required for the debug flag and it looks like I didn't use that correctly anyway.

[mimimi085181]

Well, according to microsoft DXGI 1.3 is only supported on windows 8.1+, which is why i expected this to fail. I guess that's part of the directx 11.1 features that are not supported on windows 7, or something like that.

[CrossVR]

Correct, but IDXGIFactory2 is part of DXGI 1.2, not DXGI 1.3. It's all a bit counter-intuitive since CreateDXGIFactory2 is part of DXGI 1.3.

[mimimi085181]

Now it works, thanks.

[stenzek]

LGTM

[Helios747]

1 report that this broke D3D11 on Windows 7.

https://forums.dolphin-emu.org/Thread-directx11-failed-to-create-idx-factory-object?pid=459470#pid459470

[CrossVR]

@Helios747 According to MSDN the only way this could error out on Windows 7 is if they haven't run Windows Update in a long, long time.

If it doesn't work after the platform update we could query for IDXGIFactory2 after creating an older DXGI factory. Because if it worked without crashing before, then it should already support that interface.