New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan: Fixes for window resizing #6066

Merged
merged 3 commits into from Oct 11, 2017

Conversation

2 participants
@stenzek
Contributor

stenzek commented Sep 16, 2017

Seems we are a little buggy on the latest NV dev driver in this regard. Few changes here that stop the window getting "stuck" and not rendering here. This included toggling vsync as well.

Set a flag to resize the swap chain when presenting fails:
Drivers can return VK_ERROR_OUT_OF_DATE_KHR from vkQueuePresentKHR, and we should resize the image in this case, as well as when getting it back from vkAcquireNextImageKHR.

Only use oldSwapchain in response to VK_ERROR_OUT_OF_DATE_KHR:
Seems to be required on the latest NV driver, otherwise the presented images are never shown.

stenzek added some commits Sep 16, 2017

Vulkan: Set a flag to resize the swap chain when presenting fails
Drivers can return VK_ERROR_OUT_OF_DATE_KHR from vkQueuePresentKHR, and
we should resize the image in this case, as well as when getting it back
from vkAcquireNextImageKHR.
Vulkan: Only use oldSwapchain in response to VK_ERROR_OUT_OF_DATE_KHR
Seems to be required on the latest NV driver, otherwise the presented
images are never shown.
@stenzek

This comment has been minimized.

Show comment
Hide comment
@stenzek

stenzek Oct 10, 2017

Contributor

Currently disabling the speedlimiter when in fullscreen + vsync will cause black screens on 387.xx and above. This PR also fixes that.

Contributor

stenzek commented Oct 10, 2017

Currently disabling the speedlimiter when in fullscreen + vsync will cause black screens on 387.xx and above. This PR also fixes that.

@iwubcode

From what I can tell, code LGTM. No issues on Windows AMD drivers.

@stenzek stenzek merged commit 90ca2e8 into dolphin-emu:master Oct 11, 2017

10 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details

@stenzek stenzek deleted the stenzek:vulkan-resize branch Feb 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment