New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NetPlay settings reset issue #6074

Merged
merged 1 commit into from Sep 18, 2017

Conversation

2 participants
@delroth
Member

delroth commented Sep 18, 2017

Since TryParse wasn't implemented for u16 values, it was falling back to the istringstream implementation which doesn't support hex. This caused readback issues since all u16 are written to config as hex (questionable choice imo...).

@Helios747

This comment has been minimized.

Show comment
Hide comment
@Helios747

Helios747 Sep 18, 2017

Contributor

Can confirms this fixes https://bugs.dolphin-emu.org/issues/10548

Additionally, this doesn't break existing configs, nor does it break on u32 values or ints

LGTM.

Contributor

Helios747 commented Sep 18, 2017

Can confirms this fixes https://bugs.dolphin-emu.org/issues/10548

Additionally, this doesn't break existing configs, nor does it break on u32 values or ints

LGTM.

@delroth delroth merged commit 1566f3a into dolphin-emu:master Sep 18, 2017

10 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details

@delroth delroth deleted the delroth:netplay-fix branch Sep 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment