New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt/GraphicsSettings: Fix overriden settings not being bolded #6078

Merged
merged 1 commit into from Sep 20, 2017

Conversation

4 participants
@spycrab
Contributor

spycrab commented Sep 20, 2017

No description provided.

@Helios747

This comment has been minimized.

Show comment
Hide comment
@Helios747

Helios747 Sep 20, 2017

Contributor

Bold move, PRing this.

Contributor

Helios747 commented Sep 20, 2017

Bold move, PRing this.

@Helios747 Helios747 merged commit 10b3f02 into dolphin-emu:master Sep 20, 2017

10 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
bf.setBold(true);
setFont(bf);
}
connect(&Settings::Instance(), &Settings::EmulationStateChanged, [this]() {

This comment has been minimized.

@lioncash

lioncash Sep 20, 2017

Member

Empty parameter lists on lambdas can be omitted. Just a heads-up if you didn't know.

@lioncash

lioncash Sep 20, 2017

Member

Empty parameter lists on lambdas can be omitted. Just a heads-up if you didn't know.

setFont(bf);
}
connect(&Settings::Instance(), &Settings::EmulationStateChanged, [this]() {
if (Config::GetActiveLayerForConfig(m_setting) != Config::LayerType::Base)

This comment has been minimized.

@lioncash

lioncash Sep 20, 2017

Member

Won't this bold settings, but never unbold them? Unlike the other conditional in GraphicsSlider, or is this intentional?

@lioncash

lioncash Sep 20, 2017

Member

Won't this bold settings, but never unbold them? Unlike the other conditional in GraphicsSlider, or is this intentional?

This comment has been minimized.

@Helios747

Helios747 Sep 20, 2017

Contributor

Oh, oops. yeah this will never unbold that lol

@Helios747

Helios747 Sep 20, 2017

Contributor

Oh, oops. yeah this will never unbold that lol

bf.setBold(true);
setFont(bf);
}
connect(&Settings::Instance(), &Settings::EmulationStateChanged, [this]() {

This comment has been minimized.

@ligfx

ligfx Sep 20, 2017

Contributor

Why does this need to update on EmulationStateChanged? I don't see anything that depends on the emulation state. Seems like using AddConfigChangedCallback instead is what we want.

@ligfx

ligfx Sep 20, 2017

Contributor

Why does this need to update on EmulationStateChanged? I don't see anything that depends on the emulation state. Seems like using AddConfigChangedCallback instead is what we want.

@spycrab spycrab deleted the spycrab:qt_fix_bold branch Sep 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment