New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup var naming in ISOProperties #6082

Merged
merged 1 commit into from Sep 21, 2017

Conversation

3 participants
@Helios747
Contributor

Helios747 commented Sep 20, 2017

Was poking around in ISOProperties and noticed that a lot of the vars weren't up to date with naming guidelines.

@Helios747 Helios747 requested a review from lioncash Sep 20, 2017

@lioncash

Other than that, it looks fine 👌

@shuffle2

This comment has been minimized.

Show comment
Hide comment
@shuffle2

shuffle2 Sep 20, 2017

Contributor

honestly it would be great if this could be done across the entire codebase in an automated way(?)

Contributor

shuffle2 commented Sep 20, 2017

honestly it would be great if this could be done across the entire codebase in an automated way(?)

@Helios747

This comment has been minimized.

Show comment
Hide comment
@Helios747

Helios747 Sep 20, 2017

Contributor

Tricky, because that assumes that all non-conforming vars are named the same way or similar ways.

For example, the DCBZOFF and FPRF vars are just acronyms all capped. I imagine there are some typos in var names too.

I think we could probably hit a lot of them just by somehow detecting CamelCase in class vars though.

Worth noting that I did re-word one or two vars just because they had dumb names that would have translated to absurdly long var names.

Contributor

Helios747 commented Sep 20, 2017

Tricky, because that assumes that all non-conforming vars are named the same way or similar ways.

For example, the DCBZOFF and FPRF vars are just acronyms all capped. I imagine there are some typos in var names too.

I think we could probably hit a lot of them just by somehow detecting CamelCase in class vars though.

Worth noting that I did re-word one or two vars just because they had dumb names that would have translated to absurdly long var names.

@Helios747 Helios747 merged commit 96adbb2 into dolphin-emu:master Sep 21, 2017

10 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details

@Helios747 Helios747 deleted the Helios747:isoproperties_var_cleanup branch Jan 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment