New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Adjust position of floating action button #6084

Merged
merged 1 commit into from Sep 22, 2017

Conversation

3 participants
@JosJuice
Contributor

JosJuice commented Sep 21, 2017

I cherry-picked this from PR #5281 because it was requested by https://forums.dolphin-emu.org/Thread-misplaced-floating-action-button

Before:
screenshot_20170921-154608

After:
screenshot_20170921-155027

@degasus

This comment has been minimized.

Show comment
Hide comment
@degasus

degasus Sep 21, 2017

Member

I need some fifoci way to compare those screenshots....
But whatever, I'm fine with both locations.

Member

degasus commented Sep 21, 2017

I need some fifoci way to compare those screenshots....
But whatever, I'm fine with both locations.

@mbc07

This comment has been minimized.

Show comment
Hide comment
@mbc07

mbc07 Sep 21, 2017

Contributor

So, does this new placement matches the Material Design guidelines? Otherwise I'm pretty sure someone else will open another PR in future and the cat and mouse game will resume...

Contributor

mbc07 commented Sep 21, 2017

So, does this new placement matches the Material Design guidelines? Otherwise I'm pretty sure someone else will open another PR in future and the cat and mouse game will resume...

@degasus

This comment has been minimized.

Show comment
Hide comment
@degasus

degasus Sep 22, 2017

Member

I think so. Let's just merge it.

Member

degasus commented Sep 22, 2017

I think so. Let's just merge it.

@degasus degasus merged commit 8ebdd62 into dolphin-emu:master Sep 22, 2017

10 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
@JosJuice

This comment has been minimized.

Show comment
Hide comment
@JosJuice

JosJuice Sep 22, 2017

Contributor

The guidelines say 16dp, yes. I also checked the Gmail app that was mentioned in the forum topic, and it places the button in the same place on my phone as Dolphin does after this PR.

Contributor

JosJuice commented Sep 22, 2017

The guidelines say 16dp, yes. I also checked the Gmail app that was mentioned in the forum topic, and it places the button in the same place on my phone as Dolphin does after this PR.

@JosJuice JosJuice deleted the JosJuice:fab-placement branch Sep 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment