Fix more warnings from #579 #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -20,32 +20,8 @@ void DSPHost::InterruptRequest() {} | |||
| void DSPHost::UpdateDebugger() {} | |||
|
|
|||
| // This test goes from text ASM to binary to text ASM and once again back to binary. | |||
| // Then the two binaries are compared. | |||
| bool RoundTrip(const std::vector<u16> &code1) | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Looks good to me. I fixed a few of these in my PR, but that's OK. |
|
I decided to just keep RoundTrip() for now and only fix the warning about it not being static. Also, until we come up with proper compatibility macros for printf'ing size_t values, I'm just using %z for this one because no one is going to complain about a MSVC warning in a file with tons of warnings :) |
|
Looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.