New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt: Check showFileNameColumn, sort Hidden/ResizeMode calls by enum value #6097

Merged
merged 1 commit into from Oct 11, 2017

Conversation

2 participants
@flibitijibibo
Contributor

flibitijibibo commented Oct 3, 2017

This patch adds a line to set the COL_FILE_NAME column as hidden if the config asks for it.

It also sorts the setColumnHidden and setSectionResizeMode calls based on the order that the enum values are listed in GameListModel.h. This should be harmless, but at the same time it also appears to fix a crash on my Linux PC, where the current revision crashes when trying to call setSectionResizeMode for COL_FILE_NAME. I... don't know why. I have a GDB backtrace and an excerpt from Valgrind, but it probably won't be too helpful without any lines; for some reason this does not happen in Debug mode.

@leoetlino leoetlino merged commit 408bc36 into dolphin-emu:master Oct 11, 2017

10 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment