CMake: add DOLPHIN_CXX_FLAGS option #6143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, I'm not sure I see the use for the option. Is it just to experiment with warnings for the Dolphin source? If so, wouldn't temporary modifications to the CMakeList be good enough? |
|
You could, yeah, though that interacts poorly with things like rebase or automated tooling. My use-case is mainly being able to compile with |
Orphis
reviewed
Nov 3, 2017
|
IMO passing different flags for externals and dolphin source makes sense, so I think this PR has a point. |
Lets you do fun stuff like turning off warnings globally, then re-enabling all warnings + extra warnings + warnings as errors for Dolphin only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Lets you do fun stuff like adding extra warnings + warnings as errors for Dolphin only.
Closed the original, #6137, in a momentary lapse of thinking.