Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce UTF-8 now that VS handles it sanely #6152

Merged
merged 1 commit into from Jan 8, 2020
Merged

Conversation

@bb010g
Copy link
Contributor

bb010g commented Oct 30, 2017

Follow up to #5541. Fixed in 15.3.


This change is Reviewable

@JosJuice

This comment has been minimized.

Copy link
Member

JosJuice commented Nov 19, 2017

Let's wait with merging this until we don't support the versions of VS where it gives BOMs. LGTM other than that.

@leoetlino

This comment has been minimized.

Copy link
Member

leoetlino commented May 10, 2019

Let's get this merged once #8087 is merged (which will bump the version requirement to VS2019 AFAICT).

@bb010g

This comment has been minimized.

Copy link
Contributor Author

bb010g commented May 25, 2019

Bump since that's merged?

@JosJuice

This comment has been minimized.

Copy link
Member

JosJuice commented May 25, 2019

You can still build Dolphin with VS2017, actually. It's currently possible to build with either CMake or MSBuild, and only the former requires VS2019.

@JosJuice

This comment has been minimized.

Copy link
Member

JosJuice commented Jan 8, 2020

Dolphin no longer builds on VS2017, so it's merge time. (The build failures are just because this PR is based on an old version of master.)

@JosJuice JosJuice merged commit c484276 into dolphin-emu:master Jan 8, 2020
2 of 10 checks passed
2 of 10 checks passed
lint Build failed on builder lint
Details
pr-android Build failed on builder pr-android
Details
pr-deb-dbg-x64 Build failed on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build failed on builder pr-deb-x64
Details
pr-freebsd-x64 Build failed on builder pr-freebsd-x64
Details
pr-osx-x64 Build failed on builder pr-osx-x64
Details
pr-win-dbg-x64 Build failed on builder pr-win-dbg-x64
Details
pr-win-x64 Build failed on builder pr-win-x64
Details
default Very basic checks passed, handed off to Buildbot.
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
@bb010g bb010g deleted the bb010g:patch-1 branch Jan 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.