Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce UTF-8 now that VS handles it sanely #6152

Merged
merged 1 commit into from
Jan 8, 2020

Conversation

bb010g
Copy link
Contributor

@bb010g bb010g commented Oct 30, 2017

Follow up to #5541. Fixed in 15.3.


This change is Reviewable

@JosJuice
Copy link
Member

Let's wait with merging this until we don't support the versions of VS where it gives BOMs. LGTM other than that.

@leoetlino
Copy link
Member

Let's get this merged once #8087 is merged (which will bump the version requirement to VS2019 AFAICT).

@bb010g
Copy link
Contributor Author

bb010g commented May 25, 2019

Bump since that's merged?

@JosJuice
Copy link
Member

You can still build Dolphin with VS2017, actually. It's currently possible to build with either CMake or MSBuild, and only the former requires VS2019.

@JosJuice
Copy link
Member

JosJuice commented Jan 8, 2020

Dolphin no longer builds on VS2017, so it's merge time. (The build failures are just because this PR is based on an old version of master.)

@JosJuice JosJuice merged commit c484276 into dolphin-emu:master Jan 8, 2020
@bb010g bb010g deleted the patch-1 branch January 19, 2020 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants