New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt: make GCPadWiiU a standalone dialog #6168

Merged
merged 3 commits into from Nov 11, 2017

Conversation

3 participants
@ligfx
Contributor

ligfx commented Nov 5, 2017

This makes the definition of the MappingWidget interface simpler. Creating a new MappingWindow/GCPadWiiUConfigDialog in ControllersWindow every time one is needed seems slightly wasteful, but has zero noticeable performance impact on my computer.

ligfx added some commits Nov 3, 2017

Qt GCPadWiiU: standalone dialog, not subclass of MappingWidget
It uses none of the functionality of MappingWidget or the parent MappingWindow, and complicates the definition of the MappingWidget interface.
Rename GCPadWiiU -> GCPadWiiUConfigDialog
This name better reflects its new standalone functionality.
@Helios747

This comment has been minimized.

Show comment
Hide comment
@Helios747

Helios747 Nov 7, 2017

Contributor

LGTM, I think.

Contributor

Helios747 commented Nov 7, 2017

LGTM, I think.

@leoetlino leoetlino merged commit 338bffd into dolphin-emu:master Nov 11, 2017

10 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment