New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OGL/TextureConverter: Resolve -Wmissing-variable-declaration warnings #6236

Merged
merged 2 commits into from Dec 4, 2017

Conversation

2 participants
@lioncash
Member

lioncash commented Dec 3, 2017

This warning was caused by s_encoding_render_texture and s_encoding_readback_texture not being within an anonymous namespace or not having a static specifier on them (since there's no pre-existing extern for them anywhere).

@degasus degasus merged commit 0e8c883 into dolphin-emu:master Dec 4, 2017

10 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details

@lioncash lioncash deleted the lioncash:missing-decl branch Dec 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment