Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[Android] Add support for true analog triggers. #6244
Are you sure that this only works if GCPadNew.ini and Dolphin.ini don't already exist? The code that extracts those two files says that it'll overwrite the files if they already exists, but I haven't actually tested it...
I'm fine with merging this PR, but in the future, I think it would be better to make the controller INIs actually contain the user's configuration (like on PC) rather than storing "special" values in it and having the actual configuration be stored elsewhere. Adding deadzone, radius and such should be simpler then.
I agree, making the config code more in line with the desktop version should be a priority. I'll be looking into it.
Some issues created by this include having the SharedPreferences duplicate the config code, which creates data inconsistencies if the ini files are deleted. It seems many of the controller and config code circumvents the normal code paths. For instance, I tried changing the 'DEFAULT_PAD_STICK_RADIUS' in GCPadEmu.cpp, but it had no impact. This also makes reading the Android code difficult.