New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Add support for true analog triggers. #6244

Merged
merged 1 commit into from Dec 7, 2017

Conversation

3 participants
@tramzel
Contributor

tramzel commented Dec 7, 2017

This only works if GCPadNew.ini and Dolphin.ini files are not already in the dolphin config folder. Any advice would be helpful. I'd really like to tackle the UI and wiring for deadzones, radius, etc.

[Android] Add support for true analog triggers.
This only works if GCPadNew.ini and Dolphin.ini files are not already in the dolphin config folder. Any advice would be helpful. I'd really like to tackle the UI and wiring for deadzones, radius, etc.
@JosJuice

This comment has been minimized.

Show comment
Hide comment
@JosJuice

JosJuice Dec 7, 2017

Contributor

Are you sure that this only works if GCPadNew.ini and Dolphin.ini don't already exist? The code that extracts those two files says that it'll overwrite the files if they already exists, but I haven't actually tested it...

I'm fine with merging this PR, but in the future, I think it would be better to make the controller INIs actually contain the user's configuration (like on PC) rather than storing "special" values in it and having the actual configuration be stored elsewhere. Adding deadzone, radius and such should be simpler then.

Contributor

JosJuice commented Dec 7, 2017

Are you sure that this only works if GCPadNew.ini and Dolphin.ini don't already exist? The code that extracts those two files says that it'll overwrite the files if they already exists, but I haven't actually tested it...

I'm fine with merging this PR, but in the future, I think it would be better to make the controller INIs actually contain the user's configuration (like on PC) rather than storing "special" values in it and having the actual configuration be stored elsewhere. Adding deadzone, radius and such should be simpler then.

@tramzel

This comment has been minimized.

Show comment
Hide comment
@tramzel

tramzel Dec 7, 2017

Contributor

Thanks @JosJuice!

I agree, making the config code more in line with the desktop version should be a priority. I'll be looking into it.

Some issues created by this include having the SharedPreferences duplicate the config code, which creates data inconsistencies if the ini files are deleted. It seems many of the controller and config code circumvents the normal code paths. For instance, I tried changing the 'DEFAULT_PAD_STICK_RADIUS' in GCPadEmu.cpp, but it had no impact. This also makes reading the Android code difficult.

Contributor

tramzel commented Dec 7, 2017

Thanks @JosJuice!

I agree, making the config code more in line with the desktop version should be a priority. I'll be looking into it.

Some issues created by this include having the SharedPreferences duplicate the config code, which creates data inconsistencies if the ini files are deleted. It seems many of the controller and config code circumvents the normal code paths. For instance, I tried changing the 'DEFAULT_PAD_STICK_RADIUS' in GCPadEmu.cpp, but it had no impact. This also makes reading the Android code difficult.

@degasus degasus merged commit d243b2c into dolphin-emu:master Dec 7, 2017

10 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment