New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan: Fix MSAA regression from 5.0-5968 #6246

Merged
merged 5 commits into from Jan 12, 2018

Conversation

3 participants
@stenzek
Contributor

stenzek commented Dec 8, 2017

Should hopefully fix MSAA being broken/causing cmdbuffer submit failure as of abstract readback textures.
Also centralizes the render pass creation code in the backend, knocking out ~200 lines or so.

@LuismaSP89

This comment has been minimized.

Show comment
Hide comment
@LuismaSP89

LuismaSP89 Jan 6, 2018

@stenzek Sorry, but this PR has not changed since i made the last test in https://bugs.dolphin-emu.org/issues/10690#change-731425 isn't that right? I only want to know for retesting purposes.
Thank you.

LuismaSP89 commented Jan 6, 2018

@stenzek Sorry, but this PR has not changed since i made the last test in https://bugs.dolphin-emu.org/issues/10690#change-731425 isn't that right? I only want to know for retesting purposes.
Thank you.

@stenzek

This comment has been minimized.

Show comment
Hide comment
@stenzek

stenzek Jan 6, 2018

Contributor

@LuismaSP89 that's correct. I've been out of the country for a month and haven't investigated it further - might get some time later in the week.

Contributor

stenzek commented Jan 6, 2018

@LuismaSP89 that's correct. I've been out of the country for a month and haven't investigated it further - might get some time later in the week.

@LuismaSP89

This comment has been minimized.

Show comment
Hide comment
@LuismaSP89

LuismaSP89 Jan 6, 2018

@stenzek Ok, no problem, thanks a lot.

LuismaSP89 commented Jan 6, 2018

@stenzek Ok, no problem, thanks a lot.

@stenzek

This comment has been minimized.

Show comment
Hide comment
@stenzek

stenzek Jan 11, 2018

Contributor

@LuismaSP89 should hopefully be fixed now. It works on my system at least. Also fixed a couple of validation layer fails which might cause issues on other drivers.

Contributor

stenzek commented Jan 11, 2018

@LuismaSP89 should hopefully be fixed now. It works on my system at least. Also fixed a couple of validation layer fails which might cause issues on other drivers.

@LuismaSP89

This comment has been minimized.

Show comment
Hide comment
@LuismaSP89

LuismaSP89 Jan 11, 2018

@stenzek Problem fixed ; )

LuismaSP89 commented Jan 11, 2018

@stenzek Problem fixed ; )

@JMC47

This comment has been minimized.

Show comment
Hide comment
@JMC47

JMC47 Jan 11, 2018

Contributor

LGTM

Contributor

JMC47 commented Jan 11, 2018

LGTM

@stenzek stenzek merged commit ce0c699 into dolphin-emu:master Jan 12, 2018

10 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details

@stenzek stenzek deleted the stenzek:vulkan-readback-fixes branch Feb 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment