Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMakeLists: Increment the minimum required version of wxWidgets #627

Merged
merged 1 commit into from Jul 16, 2014

Conversation

lioncash
Copy link
Member

No description provided.

@phire
Copy link
Member

phire commented Jul 14, 2014

Why?

I'll point out that the bug occurring in #620 exists in 3.0 too.

@lioncash
Copy link
Member Author

@phire Because @neobrain told me to drop 2.9.x

@neobrain
Copy link
Member

@phire because someone unintentionally decided that we don't support 2.9.x anymore, and no one can be bothered to restore support for it. Cf. https://code.google.com/p/dolphin-emu/issues/detail?id=7395 .

Ideally this shouldn't have happened and the decision to drop 2.9.x should've been made before noticing "oh crap, this doesn't actually work on what we officially support" afterwards. But well, what's done is done, I guess.

@delroth
Copy link
Member

delroth commented Jul 15, 2014

We should never have officially supported 2.9 anyway. The only reason we
ever had anything to do with 2.9 is because 3.0 took ages to get released
and we needed some 3.0 features for "something" (can't remember why
exactly). Before 2.9 even officially released as a preview build we were
using SVN exports too.

On Tue, Jul 15, 2014 at 4:05 PM, Tony Wasserka notifications@github.com
wrote:

@phire https://github.com/phire because someone unintentionally decided
that we don't support 2.9.x anymore, and no one can be bothered to restore
support for it. Cf.
https://code.google.com/p/dolphin-emu/issues/detail?id=7395 .

Ideally this shouldn't have happened and the decision to drop 2.9.x
should've been made before noticing "oh crap, this doesn't actually work on
what we officially support" afterwards. But well, what's done is done, I
guess.


Reply to this email directly or view it on GitHub
#627 (comment).

Pierre "delroth" Bourdon delroth@gmail.com
Software Engineer @ Zürich, Switzerland
http://code.delroth.net/

@lioncash
Copy link
Member Author

So is this OK to be merged now?

@phire
Copy link
Member

phire commented Jul 15, 2014

LGTM


Scott Mansell

On 16 July 2014 11:15, Lioncash notifications@github.com wrote:

So is this OK to be merged now?


Reply to this email directly or view it on GitHub
#627 (comment).

neobrain added a commit that referenced this pull request Jul 16, 2014
CMakeLists: Increment the minimum required version of wxWidgets
@neobrain neobrain merged commit 6937f7c into dolphin-emu:master Jul 16, 2014
@lioncash lioncash deleted the wx-deps branch July 16, 2014 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants