Implement the correct method for determining XFB field order. #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on advice from tueidj we implement this method based on how TVs actually determin the field order. Removes spammy messages about "Invalid field order"
|
Looks good to me. |
|
This should probably get a bit more testing before merging and Issue 7205 should be checked. |
|
@Sonicadvance1 confirms this fixes Issue 7205. I've also tested this with about 15 assorted pal and ntsc games and real/virtual XFB work perfectly. |
lioncash
added a commit
that referenced
this pull request
Jul 18, 2014
Implement the correct method for determining XFB field order.
|
Add skidau to the list of LGTMs (from the IRC) |
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Based on advice from tueidj we implement this method based on how TVs actually determine the field order.
Removes spammy log messages about "Invalid field order"
I should have done this ages ago.