Config: Set bMMU to true by default on x64 #6451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents Dolphin from crashing when the emulated software crashes. AFAIK, there is absolutely no performance to enabling this with the x64 JIT. Eventually, we should probably just remove bMMU (dolphin-emu#1831). We can't do that yet because of the ARM JIT.
|
LGTM |
|
I've been using MMU on with no performance issues for a long time, but, I can't guarantee that no game sees no perf issue from it ever. I do know that no games should be broken by it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This prevents Dolphin from crashing when the emulated software crashes.
AFAIK, there is absolutely no performance hit by enabling this with the x64 JIT.
Eventually, we should probably just remove bMMU (#1831). We can't do that yet because of the ARM JIT.