Initial implementation of the Dolphin auto-updater for Windows #6463

delroth · 2018-03-18T23:05:35Z

First of all, I would recommend reading the documentation on the Wiki: https://github.com/dolphin-emu/dolphin/wiki/Auto-update-internals

This is missing several features but should be good enough for people to start testing and contributing:

This defaults to not updating. Set "TrackForTesting" to "dev" in your Dolphin.ini to enable auto-updating. If testing from this PR, you might want to set your HashOverride in the config to some real Dolphin version from the last 2-3 months in order to get an auto-update prompt.
The updater does not have any visual cue as to what is happening. Ideally it would have a progress bar window or whatever.
Only Qt2 triggers an update check at startup, and it does so terribly because I couldn't be bothered to properly do multithreaded stuff. So expect a blocking network request on Qt2 startup if you have the option enabled.
There is no UI implemented apart from a stupidly simple Yes/No dialog. Of course this is not final.

lioncash

Basically just nits

Source/Core/DolphinQt2/Main.cpp

+class QtAutoUpdateChecker : public AutoUpdateChecker
+{
+public:
+  QtAutoUpdateChecker(QWidget* parent) : m_parent(parent) {}


Source/Core/UICommon/AutoUpdate.cpp

+
+#ifdef _WIN32
+
+const char* UPDATER_FILENAME = "Updater.exe";


Source/Core/UICommon/AutoUpdate.cpp

+  PROCESS_INFORMATION pinfo;
+  INFO_LOG(COMMON, "Updater command line: %s", UTF16ToUTF8(command_line).c_str());
+  if (!CreateProcessW(UTF8ToUTF16(reloc_updater_path).c_str(),
+                      const_cast<wchar_t*>(command_line.c_str()), NULL, NULL, FALSE, 0, NULL, NULL,


Source/Core/Updater/Main.cpp

+                             0x54, 0xdf, 0x54, 0xf4, 0x42, 0x80, 0xa6, 0x28, 0x8b, 0x6d, 0x70,
+                             0x14, 0xb5, 0x4c, 0x34, 0x95, 0x20, 0x4d, 0xd4, 0xd3, 0x5d};
+
+const char* UPDATE_TEMP_DIR = "TempUpdate";


Source/Core/Updater/Main.cpp

+
+std::string HexEncode(const u8* buffer, size_t size)
+{
+  std::string out;


Source/Core/Updater/Main.cpp

+  if (!tokenized)
+    return {};
+
+  std::vector<std::string> argv;


Source/Core/Updater/Main.cpp

+    size_t filename_end_pos = manifest.find('\t', pos);
+    if (filename_end_pos == std::string::npos)
+    {
+      fprintf(log_fp, "Manifest entry %zd: could not find filename end.\n", parsed.entries.size());


Source/Core/Updater/Main.cpp

+      TodoList::DeleteOp del;
+      del.filename = entry.first;
+      del.old_hash = entry.second;
+      todo.to_delete.push_back(del);


Source/Core/Updater/Main.cpp

+      update.filename = entry.first;
+      update.old_hash = old_hash;
+      update.new_hash = entry.second;
+      todo.to_update.push_back(update);


Source/Core/Updater/Main.cpp

+std::vector<std::string> CommandLineToUtf8Argv(PCWSTR command_line)
+{
+  int nargs;
+  LPWSTR* tokenized = CommandLineToArgvW(command_line, &nargs);


JMC47 · 2018-03-19T23:37:45Z

Personal preference - if the person auto-updates Dolphin, they probably want to run Dolphin, so, I think the updater should boot the new version of Dolphin when it's done updating.

delroth · 2018-03-19T23:39:22Z

Yeah, we can implement that later. IMO it needs to be optional, because UI-wise I think we need two modes: "Update now" and "Update when I next close Dolphin". In the latter case you don't want to restart, in the former you probably do. Could be another command line flag.

I'd like to keep anything non critical out of this PR to get as much mileage as possible as early as possible, using the fact that it's default-disabled to experiment :)

riking · 2018-03-20T03:40:57Z

(Copied from IRC conversation) Two-phase rollover for key pins should be supported by allowing for multiple signatures at the bottom of the update manifest.

The server-side logic for doing so should be pretty simple, as the client is sending the exact version they're updating from.

Updater.exe takes as input manifests and applies the difference between these manifests to an install directory. Currently lacking a UI.

…uded in default builds

The AutoUpdate module is a generic update checker mechanism which can be used by UI backends to trigger an auto-update check as well as the actual update process. Currently only configurable through .ini and the Qt implementation is completely placeholder-y -- blocking the main thread on a network request on startup, etc.

delroth · 2018-03-20T18:22:06Z

@riking done.

ghost · 2018-03-29T10:40:50Z

EDIT moved to #6496

delroth added 3 commits March 19, 2018 00:11

Import picojson to Externals from https://github.com/kazuho/picojson

891a1ee

Import ed25519 implementation from https://github.com/orlp/ed25519

0427d34

make_scmrev.h.js: set default auto-update track from environment

5498f9b

delroth force-pushed the auto-update branch from ac1f352 to 8d3f3a9 Compare March 18, 2018 23:12

lioncash reviewed Mar 19, 2018

View reviewed changes

HttpRequest: make curl initialization thread-safe

bc9deb7

delroth force-pushed the auto-update branch from 8d3f3a9 to 764b7ca Compare March 19, 2018 23:36

delroth added 3 commits March 20, 2018 19:21

Add Updater.exe which performs the update tasks.

07c1603

Updater.exe takes as input manifests and applies the difference between these manifests to an install directory. Currently lacking a UI.

DolphinWX: depend on Updater in order to make sure the binary is incl…

37902c4

…uded in default builds

delroth force-pushed the auto-update branch from 764b7ca to 66b41c5 Compare March 20, 2018 18:21

Helios747 merged commit ad8c316 into dolphin-emu:master Mar 20, 2018

Initial implementation of the Dolphin auto-updater for Windows #6463

Initial implementation of the Dolphin auto-updater for Windows #6463

delroth commented Mar 18, 2018

lioncash left a comment

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

JMC47 commented Mar 19, 2018

delroth commented Mar 19, 2018

riking commented Mar 20, 2018 •

edited

delroth commented Mar 20, 2018

ghost commented Mar 29, 2018 •

edited by ghost

Initial implementation of the Dolphin auto-updater for Windows #6463

Initial implementation of the Dolphin auto-updater for Windows #6463

Conversation

delroth commented Mar 18, 2018

lioncash left a comment

Choose a reason for hiding this comment

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

JMC47 commented Mar 19, 2018

delroth commented Mar 19, 2018

riking commented Mar 20, 2018 • edited

delroth commented Mar 20, 2018

ghost commented Mar 29, 2018 • edited by ghost

riking commented Mar 20, 2018 •

edited

ghost commented Mar 29, 2018 •

edited by ghost