GCI Folder: no need to force reload sysmenu to get region #651
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
causes crash with larger gci folders as we pull the loader out from under the ppc
|
Looks good to me. |
|
Fixes a critical sysmenu crash for me that kills Dolphin and makes it unclosable. Would prefer this merged ASAP. |
lioncash
added a commit
that referenced
this pull request
Jul 19, 2014
GCI Folder: no need to force reload sysmenu to get region
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
There is no reason to force reload when we are already running the sysmenu.
The fact that it wasn't crashing before was only because it was fast enough that it reloaded before the ppc code needed the nandloader