GCPadEmu: stop sticks wrapping at extreme values #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes and extremely annoying bug. LGTM |
|
This is my fault. The code before was doing |
|
It's not your fault, even before your merge this could happen in a lot of games. |
|
Changed the centers back to being 0x80 |
|
If the centers are 0x80 in this case, we do have a constant to represent that if it helps readability in the future: here |
|
Not really happy about the use of magic consts, but this is a fairly major bug. |
delroth
added a commit
that referenced
this pull request
Jul 19, 2014
GCPadEmu: stop sticks wrapping at extreme values
|
Interesting. I only found out the "correct" origin because of https://github.com/dolphin-emu/dolphin/blob/master/Source/Core/Core/HW/GCPad.cpp#L57 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Extreme values (i.e. -1.0) of x/y were causing the stick values to wrap