Fix two possible crashes related to the debugger. #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't a correct state for the CPU to begin in when starting the application. Also CPU_STEPPING as an initial state causes the emulator to crash if you use any of the debugger stepping buttons, since it checks if the CPU is in the CPU_STEPPING state before performing their functions.
| @@ -160,6 +160,12 @@ void CMemoryWindow::JumpToAddress(u32 _Address) | |||
|
|
|||
| void CMemoryWindow::SetMemoryValue(wxCommandEvent& event) | |||
| { | |||
| if (!Memory::IsInitialized()) | |||
| { | |||
| PanicAlertT("Cannot set uninitialized memory."); | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
LGTM |
1 similar comment
|
LGTM |
Parlane
added a commit
that referenced
this pull request
Jul 23, 2014
Fix two possible crashes related to the debugger.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
CPU_POWERDOWNshould be the default initial state of the CPU upon starting the emulator, notCPU_STEPPING, since it implies the CPU is running but is (obviously) stepping. This also prevents crashes in regards to using stepping debugging tools, since the main condition these debugging features check against isCCPU::IsStepping(), which will return true, even without the emulator running, since it is the default state.SetMemoryValue, there were no sanitizing checks for a valid state, it would just directly callMemory::Write_U32. Now it checks if memory has been properly initialized first.