Boot_WiiWAD: Remove a timing issue workaround #6611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was necessary to work around a FS timing issue which caused small writes to take much longer than they should. Now that we emulate timings for the FS module including its file cache, we don't need to maintain this workaround anymore.
BhaaLseN
approved these changes
Apr 8, 2018
|
Yep. The issue was that the system menu did tons of small writes (4 bytes...) and Dolphin was using a hardcoded tick value for all writes, ignoring the fact that FFSP has a file read/write cache which is used to fulfill small read/write requests. Now this cache is emulated and we use the correct timing for all those requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was necessary to work around a FS timing issue which caused small
writes to take much longer than they should.
Now that we emulate timings for the FS module including its file cache,
we don't need to maintain this workaround anymore.