Qt/GameList: Always sort games alphabetically #6726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoetlino
reviewed
May 1, 2018
| @@ -15,3 +15,27 @@ bool ListProxyModel::filterAcceptsRow(int source_row, const QModelIndex& source_ | |||
| GameListModel* glm = qobject_cast<GameListModel*>(sourceModel()); | |||
| return glm->ShouldDisplayGameListItem(source_row); | |||
| } | |||
|
|
|||
| #include <QDebug> | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
leoetlino
reviewed
May 1, 2018
|
|
||
| if (sortOrder() == Qt::AscendingOrder) | ||
| return leftTitle < rightTitle; | ||
| else |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
leoetlino
reviewed
May 1, 2018
|
|
||
| if (sortOrder() == Qt::AscendingOrder) | ||
| return QSortFilterProxyModel::lessThan(left, right); | ||
| else |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
leoetlino
reviewed
May 1, 2018
| // If two items are otherwise equal, compare them by their title | ||
| if (left.data(Qt::InitialSortOrderRole) == right.data(Qt::InitialSortOrderRole)) | ||
| { | ||
| const auto rightTitle = |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
lioncash
reviewed
May 2, 2018
| bool ListProxyModel::lessThan(const QModelIndex& left, const QModelIndex& right) const | ||
| { | ||
| // If two items are otherwise equal, compare them by their title | ||
| if (left.data(Qt::InitialSortOrderRole) == right.data(Qt::InitialSortOrderRole)) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
lioncash
approved these changes
May 3, 2018
lioncash
approved these changes
May 3, 2018
|
Gotta get that fat double approval in there apparently |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Even when sorting by another column (e.g. Platform) an alphabetical order within that sorting must be upheld.