Qt: Show disc number #6751
Merged
Qt: Show disc number #6751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd suggest that you only add the extra text if the name doesn't already contain the disc number, like in DolphinWX: dolphin/Source/Core/UICommon/GameFile.cpp Lines 270 to 271 in 76e1a5b |
|
@JosJuice Is this reliable though? |
|
I don't know if it covers every single game in every single language, but it seems to have worked out well enough in DolphinWX. |
|
Some braces would be nice too, but otherwise it seems to do just fine: |
spycrab
force-pushed
the
qt_show_disc
branch
3 times, most recently
from
0635211
to
f57d9bd
Compare
JosJuice
reviewed
May 4, 2018
| { | ||
| if (!name.contains(QRegExp(QStringLiteral("disc ?%1").arg(disc_nr), Qt::CaseInsensitive))) | ||
| { | ||
| name.append(game.GetDiscNumber() != 0 ? tr(" (Disc %1)").arg(disc_nr) : |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
BhaaLseN
reviewed
May 4, 2018
| { | ||
| QString name = QString::fromStdString(game.GetName()); | ||
| const int disc_nr = game.GetDiscNumber() + 1; | ||
| if (game.GetDiscNumber() != 0) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.