Fix a possible overflow in EXI_DeviceIPL. #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m_szBuffer has a size of 256, but addressable range is 0 - 255
delroth
added a commit
that referenced
this pull request
Jul 29, 2014
Fix a possible overflow in EXI_DeviceIPL.
|
It's an arbitrary limit that can be replaced with a string. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The limited size buffer can also be entirely removed and replaced with a string as well (allowing for more code cull), however I didn't know if the buffer was specifically enforced as 256 characters to represent hardware/software or something.