IOS: Make file creation + open more concise #6784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating a file then opening it in read write mode is a pretty common operation. This commit adds a helper function that makes it easier to read and clearer.
BhaaLseN
reviewed
May 8, 2018
| Result<FileHandle> FileSystem::CreateAndOpenFile(Uid uid, Gid gid, const std::string& path, | ||
| Mode owner_mode, Mode group_mode, Mode other_mode) | ||
| { | ||
| Result<FileHandle> file = OpenFile(uid, gid, path, Mode::ReadWrite); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
BhaaLseN
approved these changes
May 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Creating a file then opening it in read write mode is a pretty common operation. This commit adds a helper function that makes it easier to read and clearer.
Fixes an oversight which would cause uid.sys and cert.sys not to get created on totally empty NANDs