Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Remove the unused cycle parameter from DSPHLE update calls #679

Merged
merged 1 commit into from Aug 2, 2014

Conversation

lioncash
Copy link
Member

This can't be removed from the void DSPHLE::DSP_Update(int cycles) call, as that is part of the DSP interface (LLE uses cycles).

@phire
Copy link
Member

phire commented Aug 1, 2014

Yeah, I was looking at this.

HLE should never be concerned about cycles (and I'm actually thinking about removing this periodic update altogether.)

LGTM

@BhaaLseN
Copy link
Member

BhaaLseN commented Aug 1, 2014

I personally prefer re/formatting (and minor stuff like removing unused includes/variables/etc) to be done as separate commit, unless its directly part of the code to be changed - makes the actual changes easier to be reviewed (if you look at them commit by commit). But thats just my 2ct.

Other than that, LGTM

delroth added a commit that referenced this pull request Aug 2, 2014
Core: Remove the unused cycle parameter from DSPHLE update calls
@delroth delroth merged commit da2833c into dolphin-emu:master Aug 2, 2014
@lioncash lioncash deleted the ucode-update-params branch August 2, 2014 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants