Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fakepoll.h #680

Merged
merged 1 commit into from Jul 28, 2014
Merged

Remove fakepoll.h #680

merged 1 commit into from Jul 28, 2014

Conversation

lioncash
Copy link
Member

It was only used for Windows XP and lower.

This also bumps the _WIN32_WINNT define in the stdafx precompiled headers to set the minimum version as Windows Vista.

Credit goes to @shuffle2 for the patch.

@lioncash lioncash changed the title Removes fakepoll.h. Remove fakepoll.h Jul 27, 2014
It was only used for Windows XP and lower.

This also bumps the _WIN32_WINNT define in the stdafx precompiled headers to set the minimum version as Windows Vista.
@JMC47
Copy link
Contributor

JMC47 commented Jul 27, 2014

xaudio2 still produces audio on Windows 7 SP1 for me.

@lioncash
Copy link
Member Author

Uhh? This isn't related to anything audio.
On Jul 27, 2014 4:03 PM, "JMC47" notifications@github.com wrote:

xaudio2 still produces audio on Windows 7 SP1 for me.


Reply to this email directly or view it on GitHub
#680 (comment).

@shuffle2
Copy link
Contributor

@lioncash I asked @JMC47 to check because change to Source/Core/AudioCommon/stdafx.h may have affected it (didn't expect it to, and it didn't - but I was just making sure).

@lioncash
Copy link
Member Author

Oh OK, was a little confused there :p
On Jul 27, 2014 6:06 PM, "shuffle2" notifications@github.com wrote:

@lioncash https://github.com/lioncash I asked @JMC47
https://github.com/JMC47 to check because change to
Source/Core/AudioCommon/stdafx.h may have affected it (didn't expect it to,
and it didn't - but I was just making sure).


Reply to this email directly or view it on GitHub
#680 (comment).

@Parlane
Copy link
Member

Parlane commented Jul 27, 2014

Why is there some 0x0600 and some 0x0602 ??

@shuffle2
Copy link
Contributor

read the comments...

@Parlane
Copy link
Member

Parlane commented Jul 27, 2014

LGTM

Parlane added a commit that referenced this pull request Jul 28, 2014
@Parlane Parlane merged commit 3554a15 into dolphin-emu:master Jul 28, 2014
@lioncash lioncash deleted the fakepoll-removal branch July 28, 2014 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants