Fix hotkeys in Linux and Mac OS X #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Regarding the segfaults in GDB: Do you have fastmem disabled in the Dolphin ini? |
|
ah ofcourse, I keep forgetting about that. |
|
After debugging I still have no idea what causes this difference in behaviour between Linux and Win32. I say we just fix this quickly now and find out how to merge the two code paths later. |
|
I would add on to the comment with a FIXME or say something along the lines of ideally not needing the panel. At least this way if anyone else sees it, they could chime in and give a solution (if they have one) |
|
Done, ready for review. |
|
Looks good to me |
|
Attempting to rewrite this branch, only merge it if we're in need of a quick fix. |
Needed for hotkeys to be captured on Linux.
|
Okay, the problem has been fixed properly now, ready for review. |
CrossVR
changed the title
|
This PR also fixes issue 7536. |
CrossVR
changed the title
lioncash
added a commit
that referenced
this pull request
Aug 4, 2014
Fix hotkeys in Linux and Mac OS X
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Needed for hotkeys to function correctly on Linux and OS X.
The reason this is necessary is because a wxFrame will only receive keyboard focus if it has at least one child.