Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpreter_FPUtils: Set the FPSCR.VX bit if any invalid operation exception bits are set #6956

Merged
merged 1 commit into from May 25, 2018

Conversation

lioncash
Copy link
Member

The VX bit is intended to be a summary bit indicating the occurrence of any kind of invalid operation. Therefore, whenever an invalid operation exception is set, also set VX.

This corrects our CR flag setting for multiple instructions in certain scenarios. This corrects flag setting cases in fadd, fadds, fctiw, fctiwz, fdiv, frsp, frsqrte, fsub, and fsubs (and technically every floating-point instruction that we make more accurate in the future with regards to flag setting).

…ception bits are set

The VX bit is intended to be a summary bit indicating the occurrence of
any kind of invalid operation. Therefore, whenever an invalid operation
exception is set, also set VX.

This corrects our CR flag setting for multiple instructions in certain
scenarios. This corrects flag setting cases in fadd, fadds, fctiw, fctiwz, fdiv,
frsp, frsqrte, fsub, and fsubs (and technically every floating-point
instruction that we make more accurate in the future with regards to
flag setting).
@JMC47
Copy link
Contributor

JMC47 commented May 24, 2018

Tested a few games in this and didn't notice any differences in behavior.

@leoetlino leoetlino merged commit 56217fd into dolphin-emu:master May 25, 2018
@lioncash lioncash deleted the flag branch May 25, 2018 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants