Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Exclusive Fullscreen with 'Render to Main Window'. #703

Closed
wants to merge 3 commits into from

Conversation

CrossVR
Copy link
Contributor

@CrossVR CrossVR commented Jul 30, 2014

The RenderFrame will now be detached from the Main Window when going to fullscreen, allowing 'Render to Main Window' to support exclusive fullscreen.

Depends on PR #690.

Needs thorough testing, especially to check if it doesn't break fullscreen on platforms other than Windows.

This PR is still experimental, do not merge.

@CrossVR
Copy link
Contributor Author

CrossVR commented Jul 30, 2014

@magcius You were right about re-parenting the window, exclusive fullscreen now works thanks to that.

@archshift
Copy link
Contributor

What's the status of this?

@archshift
Copy link
Contributor

This does not work at all on OS X. After going fullscreen, I see a small white box in the center and everything else is black. The hotkeys still work though.

@shuffle2
Copy link
Contributor

Similarly broken in windows^

@CrossVR
Copy link
Contributor Author

CrossVR commented Aug 25, 2014

That's because I'm in the process of rewriting this PR.

@shuffle2
Copy link
Contributor

shuffle2 commented Sep 2, 2014

ping? would like to clear the regression of menubar in fullscreen (w/render to main)...

@CrossVR
Copy link
Contributor Author

CrossVR commented Sep 2, 2014

I'm currently preoccupied, hopefully I'll have time to fix this soon.

You could go with the other PR to just address the regression instead of
waiting on this solution.

On 02/09/14 09:31, shuffle2 wrote:

ping? would like to clear the regression of menubar in fullscreen
(w/render to main)...


Reply to this email directly or view it on GitHub
#703 (comment).

@shuffle2
Copy link
Contributor

shuffle2 commented Sep 3, 2014

Alright. I do hope to see this PR fixed up sometime though :)

@CrossVR
Copy link
Contributor Author

CrossVR commented Sep 4, 2014

I restored the old version of this PR that worked partially. But getting this PR to work properly across multiple platforms is proving very difficult due to inconsistent reparenting behaviour in wxWidgets.

I might take another shot at this PR later.

@archshift
Copy link
Contributor

Why did you close this?

@CrossVR
Copy link
Contributor Author

CrossVR commented Nov 2, 2014

The current code is not functional and it would be difficult getting this to work. Like I said I may make another attempt later, but currently this PR is just clutter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants