New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Exclusive Fullscreen with 'Render to Main Window'. #703
Conversation
|
@magcius You were right about re-parenting the window, exclusive fullscreen now works thanks to that. |
|
What's the status of this? |
|
This does not work at all on OS X. After going fullscreen, I see a small white box in the center and everything else is black. The hotkeys still work though. |
|
Similarly broken in windows^ |
|
That's because I'm in the process of rewriting this PR. |
|
ping? would like to clear the regression of menubar in fullscreen (w/render to main)... |
|
I'm currently preoccupied, hopefully I'll have time to fix this soon. You could go with the other PR to just address the regression instead of On 02/09/14 09:31, shuffle2 wrote:
|
|
Alright. I do hope to see this PR fixed up sometime though :) |
This more closely matches wxWidgets.
…to main." This reverts commit fd2343e.
4155296
to
86ed5e3
Compare
|
I restored the old version of this PR that worked partially. But getting this PR to work properly across multiple platforms is proving very difficult due to inconsistent reparenting behaviour in wxWidgets. I might take another shot at this PR later. |
86ed5e3
to
67a33fc
Compare
|
Why did you close this? |
|
The current code is not functional and it would be difficult getting this to work. Like I said I may make another attempt later, but currently this PR is just clutter. |
The RenderFrame will now be detached from the Main Window when going to fullscreen, allowing 'Render to Main Window' to support exclusive fullscreen.
Depends on PR #690.
Needs thorough testing, especially to check if it doesn't break fullscreen on platforms other than Windows.
This PR is still experimental, do not merge.