Set 0x0000002C to NDEV 2.1 when running a debug-signed Wii disc #7092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delroth
reviewed
Jun 7, 2018
| @@ -22,7 +22,7 @@ bool CBoot::BootNANDTitle(const u64 title_id) | |||
| }); | |||
|
|
|||
| auto* ios = IOS::HLE::GetIOS(); | |||
| SetupWiiMemory(); | |||
| SetupWiiMemory(false); | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Source/Core/Core/Boot/Boot.h
Outdated
| @@ -116,7 +116,7 @@ class CBoot | |||
| static bool Load_BS2(const std::string& boot_rom_filename); | |||
|
|
|||
| static void SetupGCMemory(); | |||
| static bool SetupWiiMemory(); | |||
| static bool SetupWiiMemory(bool devkit); | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Here's a screenshot of The Last Story v2340 running in Dolphin with this patch: |
This fixes the The Last Story prototype that GerbilSoft was testing, because the apploader is a bit more lenient with the max size of DOL sections when it detects that you're using a devkit console.
|
LGTM. Would appreciate if @leoetlino reviewed the IOS/ES-heavy parts of the code before merging, but the logic made sense to me. Thanks! |
leoetlino
approved these changes
Jun 7, 2018
|
If this is just a matter of setting a memory address, could there not be a UI option to select the console type? |
|
There is no real reason for users to change this. It could even break stuff depending on what assumptions games make. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the The Last Story prototype that @GerbilSoft was testing, because the apploader is a bit more lenient with the max size of DOL sections when it detects that you're using a devkit console.