Core: Clean up coding style in the Interpreter #715

lioncash · 2014-08-02T06:42:51Z

No description provided.

Source/Core/Core/PowerPC/Interpreter/Interpreter_FloatingPoint.cpp

@@ -129,7 +131,10 @@ void Interpreter::fctiwx(UGeckoInstruction _inst)
 			{
 				double t = b + 0.5;
 				i = (s32)t;
-				if (t - i < 0 || (t - i == 0 && b > 0)) i--;
+
+				if (t - i < 0 || (t - i == 0 && b > 0))


BhaaLseN · 2014-08-02T10:22:20Z

Always yay for cleanup, and LGTM, but...
those 3 ifs inside fctwix feel like they should the same style to me (either with brackets, even tho they are one-liners; or without, because they are just one-liners). We don't really have a concrete rule "do it like this", only a "you can if its clear" - but in that case, when looking at a diff, it arises the question on why it uses a mix (and whether something intended is missing, or its just pure coincidence).

Source/Core/Core/PowerPC/Interpreter/Interpreter.cpp

+void Interpreter::RunTable19(UGeckoInstruction _inst) { m_opTable19[_inst.SUBOP10](_inst); }
+void Interpreter::RunTable31(UGeckoInstruction _inst) { m_opTable31[_inst.SUBOP10](_inst); }
+void Interpreter::RunTable59(UGeckoInstruction _inst) { m_opTable59[_inst.SUBOP5 ](_inst); }
+void Interpreter::RunTable63(UGeckoInstruction _inst) { m_opTable63[_inst.SUBOP10](_inst); }


Tilka · 2014-08-02T11:37:45Z

lgtm in the sense that I scrolled through and nothing caught my eye.

Core: Clean up coding style in the Interpreter

BhaaLseN reviewed Aug 2, 2014
View reviewed changes

Tilka reviewed Aug 2, 2014
View reviewed changes

Core: Clean up coding style in the Interpreter

8467c82

lioncash added a commit that referenced this pull request Aug 2, 2014

Merge pull request #715 from lioncash/interp

a723fd3

Core: Clean up coding style in the Interpreter

lioncash merged commit a723fd3 into dolphin-emu:master Aug 2, 2014

lioncash deleted the interp branch August 2, 2014 12:39

Core: Clean up coding style in the Interpreter #715

Core: Clean up coding style in the Interpreter #715

lioncash commented Aug 2, 2014

This comment was marked as off-topic.

This comment was marked as off-topic.

BhaaLseN commented Aug 2, 2014

This comment was marked as off-topic.

Tilka commented Aug 2, 2014

Core: Clean up coding style in the Interpreter #715

Core: Clean up coding style in the Interpreter #715

Conversation

lioncash commented Aug 2, 2014

This comment was marked as off-topic.

This comment was marked as off-topic.

BhaaLseN commented Aug 2, 2014

This comment was marked as off-topic.

Tilka commented Aug 2, 2014