New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make vertex loader testable #716
Conversation
|
|
||
| TEST(VertexLoaderUID, UniqueEnough) | ||
| { | ||
| std::set<VertexLoaderUID> uids; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
…enerator and VertexManager)
| @@ -57,16 +53,10 @@ void ControllerInterface::Initialize() | |||
| ciface::XInput::Init(m_devices); | |||
| #endif | |||
| #ifdef CIFACE_USE_XLIB | |||
| #if USE_EGL | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
I think you missed D3D, its also doing the |
|
As said on IRC, D3D is a mess of its own, and can be dealt with in a followup PR. This fixes what's needed to get tests working, I'm not trying to fix the whole module isolation problem that Dolphin has in one go. |
Isolate D3D and Software Renderer from wxWidgets code
|
@BhaaLseN D3D and Software renderer are taken care of now. |
|
LGTM |
This branch contains some core refactorings and global dependencies removal to make VertexLoader testable. A sample unit test has been included, and while it does not test much (a simple position conversion test) it works fine, even testing JIT :)