Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make vertex loader testable #716

Merged
merged 7 commits into from Aug 4, 2014
Merged

Conversation

delroth
Copy link
Member

@delroth delroth commented Aug 2, 2014

This branch contains some core refactorings and global dependencies removal to make VertexLoader testable. A sample unit test has been included, and while it does not test much (a simple position conversion test) it works fine, even testing JIT :)


TEST(VertexLoaderUID, UniqueEnough)
{
std::set<VertexLoaderUID> uids;

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

@@ -57,16 +53,10 @@ void ControllerInterface::Initialize()
ciface::XInput::Init(m_devices);
#endif
#ifdef CIFACE_USE_XLIB
#if USE_EGL

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

@BhaaLseN
Copy link
Member

BhaaLseN commented Aug 2, 2014

I think you missed D3D, its also doing the VideoConfigDialog mumbo jumbo in VideoBackend::ShowConfig.

@delroth
Copy link
Member Author

delroth commented Aug 3, 2014

As said on IRC, D3D is a mess of its own, and can be dealt with in a followup PR. This fixes what's needed to get tests working, I'm not trying to fix the whole module isolation problem that Dolphin has in one go.

@lioncash
Copy link
Member

lioncash commented Aug 4, 2014

@BhaaLseN D3D and Software renderer are taken care of now.

@lioncash
Copy link
Member

lioncash commented Aug 4, 2014

LGTM

delroth added a commit that referenced this pull request Aug 4, 2014
@delroth delroth merged commit e15ec56 into dolphin-emu:master Aug 4, 2014
@delroth delroth deleted the vertex-loader branch August 4, 2014 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants