DSP: copy audio dma samples as early as possible #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like the previous implem was more accurate - any idea what's going wrong? |
|
Not sure what is causing this, but the change isn't a big deal - it just does the dma as a single chunk as soon as it is issued rather than 32bytes @ 4Hz. The previous impl. had other issues (iirc, it could miss the first dma xfer of a stream entirely if the source/length registers got updated before it actually copied). |
delroth
added a commit
that referenced
this pull request
Aug 2, 2014
DSP: copy audio dma samples as early as possible
|
Since this seems to cause issues on both sides, this could be made into a GameINI setting to start with, to avoid hack requirements. My $0.02. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Xenoblade Chronicles has problems when samples were copied gradually rather than all-at-once.
This restores the all-at-once behaviour.
It also removes the check for num_blocks==0 at the start of the audio-dma stream (this should never happen).