GC USB Adapter configuration improvements #7291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BhaaLseN
reviewed
Jul 28, 2018
lioncash
reviewed
Jul 29, 2018
| } | ||
|
|
||
| if (error_message) | ||
| *error_message = libusb_strerror((enum libusb_error)s_status); |
There was a problem hiding this comment.
static_cast<libusb_error>(s_status)
VinDuv
force-pushed
the
gc-adapter-error-report
branch
from
6a807f3
to
09c9cbf
Compare
|
Updated PR; I fixed the issues (except for the use of named constants in |
VinDuv
force-pushed
the
gc-adapter-error-report
branch
from
09c9cbf
to
955f860
Compare
Techjar
reviewed
Jul 30, 2018
VinDuv
force-pushed
the
gc-adapter-error-report
branch
from
955f860
to
18828b4
Compare
|
Updated PR:
|
VinDuv
force-pushed
the
gc-adapter-error-report
branch
from
18828b4
to
8d804d6
Compare
leoetlino
previously requested changes
May 25, 2019
VinDuv
force-pushed
the
gc-adapter-error-report
branch
from
8d804d6
to
d40df4f
Compare
|
It looks like you forgot the libusb error enum change. |
VinDuv
force-pushed
the
gc-adapter-error-report
branch
from
d40df4f
to
f4b598d
Compare
|
Could you rebase this again please? |
The handle was previously kept open, which was causing future adapter plug/unplug events to be ignored.
If opening the adapter fails, report the libusb error message in the GUI instead of “No Adapter Detected”. The error condition is removed when the adapter is unplugged.
Update the GC adapter config GUI if the adapter is plugged or unplugged.
Detect when the setup function found no adapter, or found one but could not connect to it, and report the new status in that case.
Fix the Android version of GCAdapter.cpp so it matches the new definitions in GCAdapter.h.
VinDuv
force-pushed
the
gc-adapter-error-report
branch
from
f4b598d
to
2c3c8bb
Compare
|
Done. I’ve also removed the extraneous |
leoetlino
approved these changes
May 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some improvements to the GameCube USB adapter configuration process:
Caveats:
libusb_setlocalewith a locale string. I did not implement this because I wasn’t sure where to put the call and how to get the current locale in a cross-platform manner.