Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoCommon/HiresTextures: Change wildcard to a Windows-compatible character #7349

Merged
merged 1 commit into from Aug 22, 2018

Conversation

Techjar
Copy link
Contributor

@Techjar Techjar commented Aug 21, 2018

Windows is dumb and doesn't let you put special characters into file names like other operating systems do, so this feature was more or less impossible to use.

@degasus
Copy link
Member

degasus commented Aug 21, 2018

Maybe we should support both wildcards for a while.

@BigheadSMZ
Copy link

Thanks! As far as Wind Waker goes, this fixes the boss key using the name:
tex1_48x51_53403146169829a2_$_9

None of the other textures are affected in that game, so that is as much as I can test.

@BhaaLseN
Copy link
Member

I kinda doubt that any (significant) packs use the asterisk, since it doesn't work on Windows.
Or, any at all, since not even we devs knew this feature existed.

@emu82-1
Copy link

emu82-1 commented Aug 22, 2018

I can confirm that this effectively fixes the problem with the HUD items in Twilight Princess (Wii version). Thank you.

  • Slingshot: tex1_40x62_845fe9fec72c4909_$_9
  • Hawkeye: tex1_48x45_b0e063510a4f1e9e_$_9
  • Morning Star: tex1_56x47_f5d5a5148193e7a1_$_9
  • Spider Bomb: tex1_56x45_2117f87b166cc69e_$_9

@delroth delroth merged commit 74cbc6c into dolphin-emu:master Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
6 participants