Fix hotkeys in Linux and Mac OS X (properly this time). #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to fix the hotkeys on those platforms.
CrossVR
changed the title
CrossVR
changed the title
|
lgtm...some *nix user should check and merge. |
|
Why is it needed? |
|
Because for some reason wxWidgets won't allow a wxFrame without children to receive keyboard focus, but only on Linux and OS X. |
|
Shouldn't this be done at initialization of |
|
This is the initialization of |
|
I can confirm that this fixes the issue with hotkeys not working during gameplay on Linux. |
|
Really not a big fan of this fix, but meh... I'll just blame WX for being terrible. |
delroth
added a commit
that referenced
this pull request
Aug 14, 2014
Fix hotkeys in Linux and Mac OS X (properly this time).
mwoehlke
referenced
this pull request
Aug 17, 2014
Also remove x, y, width and height from the GLInterface, since it's only used in GLX, which no longer uses them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This is needed to fix the hotkeys on those platforms.
Proper fix this time, in the end I was unable to merge the two code paths since the behaviour is very different between these platforms.
Note that the panel is now actually used for rendering instead of obscuring the renderer. So there is no way for the same problem to happen on Linux and Mac OS X.