Restore Wayland compatibility. #737
Merged
+14
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was broken by e15ec56 because it wasn't deemed important. However chances are people will eventually start using Dolphin on that configuration, so we shouldn't frivolously drop compatibility without good reason.
Interface design issues prevent this test from linking correctly. Until this issue is resolved, we'll disable the tests for now.
neobrain
added a commit
that referenced
this pull request
Aug 6, 2014
Restore Wayland compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Wayland compatibility was broken by e15ec56 because it wasn't deemed important. However chances are people will eventually start using Dolphin on that configuration, so we shouldn't frivolously drop compatibility without good reason.
This patch reintroduces the removed code portions with slightly cleaner coding style. Other than that, the VertexLoader UnitTest has been disabled when USE_EGL is enabled. This is an issue with PR #716, which didn't deem our Wayland support code important enough to justify further fixup of the interfaces. Ideally we'd fix this, but for lack of a time-efficient solution I'd just like to restore application compatibility for now.