[WIP] Qt/GameList: Add option for full covers in grid mode #7388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Techjar
force-pushed
the
qt-large-game-covers
branch
4 times, most recently
from
432af6a
to
68ee655
Compare
delroth
reviewed
Aug 31, 2018
| @@ -151,12 +151,17 @@ void InterfacePane::CreateUI() | |||
| m_checkbox_use_userstyle = new QCheckBox(tr("Use Custom User Style")); | |||
| m_checkbox_use_covers = | |||
| new QCheckBox(tr("Download Game Covers from GameTDB.com for Use in Grid Mode")); | |||
| m_checkbox_use_full_covers = new QCheckBox(tr("Download Full Game Covers")); | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Techjar
force-pushed
the
qt-large-game-covers
branch
from
68ee655
to
fddddba
Compare
Techjar
changed the title
Techjar
force-pushed
the
qt-large-game-covers
branch
from
fddddba
to
4a33bc1
Compare
|
Is this still wanted? @MayImilae maybe you should look at this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This uses the full size (1024x680) covers from GameTDB. The size of these images necessitated caching the decompressed data, as otherwise doing anything with the game list (including scrolling) was obscenely slow with even a fairly small game library. Particularly large libraries may take a long time to load with this option enabled.
TODO: Proper placeholder game cover.