New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include SRAM in savestates #7396
Conversation
|
|
|
@Techjar Games like Pokemon Colosseum have further checks than normal games on top of this change, you also need to only load savestates that are after the last normal save if you have S1, S2, S3 and then do a normal save, and make S4, S5, S6. you can only load s4/5/6 otherwise you will have the same problem |
|
@LPFaint99 Yeah JMC47 inforned me that this game has some SRAM-related checks. I wonder what it's doing. As for the other part of the issue, I encountered that when testing other games. We don't have a good fix for it at this time, but if this at least partially fixes Pokemon Colosseum (so that it only has the same issue as every other game) then I guess we can merge it. |
|
Should probably include the game in the commit message description as one game that needs it for example sake, so it's stored in the repository history. |
766d17f
to
5cb7fa5
Compare
5cb7fa5
to
3b382c6
Compare
3b382c6
to
d0210e1
Compare
d0210e1
to
dfebb9f
Compare
This fixes an issue with saving after loading a savestate in Pokemon Colosseum.
dfebb9f
to
0eb9ac7
Compare
This fixes an issue with saving after loading a savestate in Pokemon Colosseum. Also seems like a good idea anyways, as SRAM is part of system state after all. Should we add a flag to not write the SRAM back to disk if it was loaded from a savestate?