VideoCommon: Skip vsync if configured emulation speed is not 100% #7398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't make much sense to try to vsync at weird framerates, and vsync actually causes the speed setting to not work as expected.
|
Nevermind! Misunderstood what it was. |
|
@MayImilae This is not adaptive vsync, so adding an option for it would make no sense. This only reads the configured emulation speed (i.e. the dropdown menu in general config), and has no relation to the actual emulation speed as seen in the window title. |
MayImilae
approved these changes
Sep 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
It doesn't make much sense to try to vsync at weird framerates, and vsync actually causes the speed setting to not work as expected.
This also fixes the catch-up in NetPlay host input authority mode not working when vsync is enabled.