Fix Starfox Assault from accessing out of bounds memory. #7409
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This limit was chosen based on the requirement for Metroid Prime 3's GameCube Beta. By setting it to 0x03FFFFFF (48MB) we can still use the modification to REAL_RAM in order to make the beta work. My previous implementation broke the Beta, but this one has a limit that makes more sense while still fixing Star Fox Assault.
|
For reference, the old PR was #4303. |
|
Also isn't that 64MB, not 48MB? |
|
We should probably leave a few comments in the source on where those numbers came from; it took us a while even back in the old PR to figure out what this was supposed to be doing and why the masks were what they were. |
|
I'd be fine with leaving more comments if I knew what comments I should be leaving. |
|
Should I close this or is there anything to add? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This limit was chosen based on the requirement for Metroid Prime 3's
GameCube Beta. By setting it to 0x03FFFFFF (64MB) we can still use the
modification to REAL_RAM in order to make the beta work. My previous
implementation broke the beta, but this one has a limit that makes more
sense while still fixing Star Fox Assault.
For what it's worth, the minimum the Metroid Prime 3 beta wants is 48MB. I don't think we can mask at 0x02FFFFFFF though based on the reaction to me suggesting that on IRC>