Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Starfox Assault from accessing out of bounds memory. #7409

Closed
wants to merge 1 commit into from

Conversation

@JMC47
Copy link
Contributor

commented Sep 11, 2018

This limit was chosen based on the requirement for Metroid Prime 3's
GameCube Beta. By setting it to 0x03FFFFFF (64MB) we can still use the
modification to REAL_RAM in order to make the beta work. My previous
implementation broke the beta, but this one has a limit that makes more
sense while still fixing Star Fox Assault.

For what it's worth, the minimum the Metroid Prime 3 beta wants is 48MB. I don't think we can mask at 0x02FFFFFFF though based on the reaction to me suggesting that on IRC>

Fix Starfox Assault from accessing out of bounds memory.
This limit was chosen based on the requirement for Metroid Prime 3's
GameCube Beta.  By setting it to 0x03FFFFFF (48MB) we can still use the
modification to REAL_RAM in order to make the beta work.  My previous
implementation broke the Beta, but this one has a limit that makes more
sense while still fixing Star Fox Assault.
@AdmiralCurtiss

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2018

For reference, the old PR was #4303.

@AdmiralCurtiss

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2018

Also isn't that 64MB, not 48MB?

@BhaaLseN

This comment has been minimized.

Copy link
Member

commented Sep 12, 2018

We should probably leave a few comments in the source on where those numbers came from; it took us a while even back in the old PR to figure out what this was supposed to be doing and why the masks were what they were.

@JMC47

This comment has been minimized.

Copy link
Contributor Author

commented Sep 13, 2018

I'd be fine with leaving more comments if I knew what comments I should be leaving.

@JMC47

This comment has been minimized.

Copy link
Contributor Author

commented Nov 9, 2018

Should I close this or is there anything to add?

@JMC47 JMC47 added the QA done label Jan 2, 2019

@JMC47 JMC47 closed this May 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.